yemai/bizhang_-obav
1
0
Fork 0
mirror of https://gitee.com/xiaohuolufeihua/bizhang_-obav.git synced 2026-05-22 01:12:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

sdlog2: fix Segfault on Eagle (#4638)

Browse Source 
Since orb_exist doesn't work on the Snapdragon Linux side, we need to do
an additional orb_check after the orb_subscribe_multi, otherwise we copy
garbage.

The segfault was triggered by a count/length information about ESC
packets which lead to access outside the struct in the garbage case.
This commit is contained in:
Julian Oes
2016-05-25 21:50:23 +02:00
committed by Lorenz Meier
parent d9718d0d98
commit af06737e7e
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/modules/sdlog2/sdlog2.c
View File

@@ -917,8 +917,13 @@ bool copy_if_updated_multi(orb_id_t topic, int multi_instance, int *handle, void
*handle = orb_subscribe_multi(topic, multi_instance);
/* copy first data */
if (*handle >= 0) {
orb_copy(topic, *handle, buffer);
updated = true;
/* but only if it has really been updated */
orb_check(*handle, &updated);
if (updated) {
orb_copy(topic, *handle, buffer);
}
}
}
} else {