mavlink_command_sender: instantiate in initialize

src/modules/mavlink/mavlink_command_sender.cpp

@@ -42,25 +42,20 @@
 #include <px4_log.h>
 #include <cassert>
 
-bool MavlinkCommandSender::_init = false;
 MavlinkCommandSender *MavlinkCommandSender::_instance = nullptr;
 px4_sem_t MavlinkCommandSender::_lock;
 
 void MavlinkCommandSender::initialize()
 {
-	if (_init) {
-		return;
-	}
-
 	px4_sem_init(&_lock, 1, 1);
-	_init = true;
+
+	if (_instance == nullptr) {
+		_instance = new MavlinkCommandSender();
+	}
 }
 
 MavlinkCommandSender &MavlinkCommandSender::instance()
 {
-	if (_instance == nullptr) {
-		_instance = new MavlinkCommandSender();
-	}
 
 	return *_instance;
 }

src/modules/mavlink/mavlink_command_sender.h

@@ -98,10 +98,7 @@ private:
 		px4_sem_post(&_lock);
 	}
 
-
-	static bool _init;
 	static MavlinkCommandSender *_instance;
-
 	static px4_sem_t _lock;
 
 	// There are MAVLINK_COMM_0 to MAVLINK_COMM_3, so it should be 4.