From 21f5f9fba08ca1cfcdc6c3e052783b013b58e65b Mon Sep 17 00:00:00 2001 From: Lorenz Meier Date: Sat, 13 Mar 2021 00:21:27 +0100 Subject: [PATCH] Param: Print failing param name This is important for any sort of boot logs to know which parameter failed. --- src/systemcmds/param/param.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/systemcmds/param/param.cpp b/src/systemcmds/param/param.cpp index 42693cb156..1bacd6706b 100644 --- a/src/systemcmds/param/param.cpp +++ b/src/systemcmds/param/param.cpp @@ -289,7 +289,7 @@ param_main(int argc, char *argv[]) return do_set(argv[2], argv[3], false); } else { - PX4_ERR("not enough arguments.\nTry 'param set PARAM_NAME 3 [fail]'"); + PX4_ERR("not enough arguments.\nTry 'param set %s 3 [fail]'", (argc > 2) ? argv[2] : "PARAM_NAME"); return 1; } } @@ -299,7 +299,7 @@ param_main(int argc, char *argv[]) return do_set_custom_default(argv[2], argv[3]); } else { - PX4_ERR("not enough arguments.\nTry 'param set-default PARAM_NAME 3'"); + PX4_ERR("not enough arguments.\nTry 'param set-default %s 3'", (argc > 2) ? argv[2] : "PARAM_NAME"); return 1; } } @@ -312,7 +312,7 @@ param_main(int argc, char *argv[]) return do_compare(argv[2], &argv[3], argc - 3, COMPARE_OPERATOR::EQUAL, COMPARE_ERROR_LEVEL::DO_ERROR); } else { - PX4_ERR("not enough arguments.\nTry 'param compare PARAM_NAME 3'"); + PX4_ERR("not enough arguments.\nTry 'param compare %s 3'", (argc > 2) ? argv[2] : "PARAM_NAME"); return 1; } } @@ -325,7 +325,7 @@ param_main(int argc, char *argv[]) return do_compare(argv[2], &argv[3], argc - 3, COMPARE_OPERATOR::GREATER, COMPARE_ERROR_LEVEL::DO_ERROR); } else { - PX4_ERR("not enough arguments.\nTry 'param greater PARAM_NAME 3'"); + PX4_ERR("not enough arguments.\nTry 'param greater %s 3'", (argc > 2) ? argv[2] : "PARAM_NAME"); return 1; } } @@ -384,7 +384,7 @@ param_main(int argc, char *argv[]) return do_find(argv[2]); } else { - PX4_ERR("not enough arguments.\nTry 'param find PARAM_NAME'"); + PX4_ERR("not enough arguments.\nTry 'param find %s'", (argc > 2) ? argv[2] : "PARAM_NAME"); return 1; } }