Tools/astyle/check_code_style.sh

#!/usr/bin/env bash

FILE=$1
DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )

if [ -f "$FILE" ]; then
	CHECK_FAILED=$(${DIR}/fix_code_style.sh --dry-run --formatted $FILE)
	if [ -n "$CHECK_FAILED" ]; then
		${DIR}/fix_code_style.sh --quiet < $FILE > $FILE.pretty

		echo
		git --no-pager diff --no-index --minimal --histogram --color=always $FILE $FILE.pretty
		rm -f $FILE.pretty
		echo

		if [[ $PX4_ASTYLE_FIX -eq 1 ]]; then
			${DIR}/fix_code_style.sh $FILE
		else
			echo $FILE 'bad formatting, please run "make format" or "./Tools/astyle/fix_code_style.sh' $FILE'"'
			exit 1
		fi
	fi
fi
add make check_format to check astyle code formatting 2015-01-05 23:16:30 -05:00			`#!/usr/bin/env bash`

filtering files for code check seperately to enable fast use of git pre-commit hook to check code style ask user to install pre-commit hook when code style is checked 2016-08-22 23:20:27 +02:00			`FILE=$1`
check code style parallel 2016-04-21 17:29:49 -04:00			`DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )`

filtering files for code check seperately to enable fast use of git pre-commit hook to check code style ask user to install pre-commit hook when code style is checked 2016-08-22 23:20:27 +02:00			`if [ -f "$FILE" ]; then`
astyle: fix display language dependency The shell script which checks the style relies on greping for the keyword "Formatted" in the output of astyle. But the program has localization support and will output in other languages e.g. german. This leads to all style checks always succeeding. I only tested this on Windows in Cygwin but I can imagine the problem also exists in non-english Ubuntu installations. Solution is the parameter --formatted of astyle which only produces any output if there was something to fix. This allows for a display language independent condition for an empty string inside the shell script. 2018-05-08 11:48:08 +01:00			`CHECK_FAILED=$(${DIR}/fix_code_style.sh --dry-run --formatted $FILE)`
astyle: switch condition to empty string check Thanks to @bkueang 's review comment I switched to an explicit check for an empty sting instead of a condition that could be theoretically true in other cases and is less readable. Type "man test" on your terminal to read up what -n stands for. 2018-05-08 17:04:26 +01:00			`if [ -n "$CHECK_FAILED" ]; then`
filtering files for code check seperately to enable fast use of git pre-commit hook to check code style ask user to install pre-commit hook when code style is checked 2016-08-22 23:20:27 +02:00			`${DIR}/fix_code_style.sh --quiet < $FILE > $FILE.pretty`
show bad formatting diff 2016-06-21 11:49:42 -04:00
			`echo`
filtering files for code check seperately to enable fast use of git pre-commit hook to check code style ask user to install pre-commit hook when code style is checked 2016-08-22 23:20:27 +02:00			`git --no-pager diff --no-index --minimal --histogram --color=always $FILE $FILE.pretty`
			`rm -f $FILE.pretty`
show bad formatting diff 2016-06-21 11:49:42 -04:00			`echo`

filtering files for code check seperately to enable fast use of git pre-commit hook to check code style ask user to install pre-commit hook when code style is checked 2016-08-22 23:20:27 +02:00			`if [[ $PX4_ASTYLE_FIX -eq 1 ]]; then`
			`${DIR}/fix_code_style.sh $FILE`
add make format (check_code_style_all.sh --fix) 2016-08-05 22:23:32 -04:00			`else`
astyle scripting move to Tools/astyle 2017-08-22 18:15:24 -04:00			`echo $FILE 'bad formatting, please run "make format" or "./Tools/astyle/fix_code_style.sh' $FILE'"'`
add make format (check_code_style_all.sh --fix) 2016-08-05 22:23:32 -04:00			`exit 1`
			`fi`
check_code_style don't create tmp files 2016-04-24 19:25:31 -04:00			`fi`
add make check_format to check astyle code formatting 2015-01-05 23:16:30 -05:00			`fi`