yemai/CherryUSB
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(port/ehci): Fix the urb leak when there is no data in the control transmission

Browse Source
This commit is contained in:
mlwang
2025-07-10 21:33:24 +08:00
committed by sakumisu
parent 9de928d6af
commit 4093a3b01d
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
port/ehci/usb_hc_ehci.c
View File

@@ -336,10 +336,8 @@ static struct ehci_qh_hw *ehci_control_urb_init(struct usbh_bus *bus, struct usb
} }
qtd_setup = ehci_qtd_alloc(bus); qtd_setup = ehci_qtd_alloc(bus);
qtd_data = ehci_qtd_alloc(bus);
qtd_status = ehci_qtd_alloc(bus); qtd_status = ehci_qtd_alloc(bus);
USB_ASSERT_MSG(qtd_setup && qtd_status, "ctrl qtd alloc failed");
USB_ASSERT_MSG(qtd_setup && qtd_data && qtd_status, "ctrl qtd alloc failed");
ehci_qh_fill(qh, ehci_qh_fill(qh,
urb->hport->dev_addr, urb->hport->dev_addr,
@@ -363,6 +361,9 @@ static struct ehci_qh_hw *ehci_control_urb_init(struct usbh_bus *bus, struct usb
/* fill data qtd */ /* fill data qtd */
if (setup->wLength > 0) { if (setup->wLength > 0) {
qtd_data = ehci_qtd_alloc(bus);
USB_ASSERT_MSG(qtd_data, "ctrl qtd alloc failed");
if ((setup->bmRequestType & 0x80) == 0x80) { if ((setup->bmRequestType & 0x80) == 0x80) {
token = QTD_TOKEN_PID_IN; token = QTD_TOKEN_PID_IN;
} else { } else {