yemai/ArduinoCore-AT32F4
1
0
Fork 0
mirror of https://github.com/WeActStudio/ArduinoCore-AT32F4.git synced 2026-05-21 09:22:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

String: Fix remove method

Browse Source 
strncpy() can not use overlapped memory regions and generates corrupted data
with certain inputs. Changed to memmove. Verified with fuzzing against
std::string::erase.
This commit is contained in:
Chris
2022-09-18 04:03:22 -04:00
parent c2ac620686
commit ecd958e50e
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cores/arduino/WString.cpp
View File

@@ -735,7 +735,7 @@ void String::remove(unsigned int index, unsigned int count)
} }
char *writeTo = buffer + index; char *writeTo = buffer + index;
len = len - count; len = len - count;
strncpy(writeTo, buffer + index + count, len - index); memmove(writeTo, buffer + index + count, len - index);
buffer[len] = 0; buffer[len] = 0;
} }